Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micropolis: fix build (patch changed) #23269

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Feb 28, 2017

Motivation for this change

The patch file changed. The current patch applies, build succeeds and game is playable.

One less build failure for #23253 :)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@fadenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edolstra and @vcunat to be potential reviewers.

@fpletz fpletz added this to the 17.03 milestone Feb 28, 2017
@fpletz fpletz added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 28, 2017
@fpletz fpletz merged commit 3c16812 into NixOS:master Feb 28, 2017
@fpletz fpletz deleted the micropolis_fix branch February 28, 2017 11:53
fpletz pushed a commit that referenced this pull request Feb 28, 2017
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 28, 2017
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants