Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitflow: tweak for darwin #23270

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Feb 28, 2017

On Darwin, wrap the git-flow binary and set:

FLAGS_GETOPT_CMD=${getopt}/bin/getopt

Without this change, I was getting the following error:

flags:ERROR short flag required for (showcommands) on this platform
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

On Darwin, wrap the git-flow binary and set:

    FLAGS_GETOPT_CMD=${getopt}/bin/getopt

Without this change, I was getting the following error:

    flags:ERROR short flag required for (showcommands) on this platform
@mention-bot
Copy link

@yurrriq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jgeerds and @offlinehacker to be potential reviewers.

@fpletz fpletz added the 6.topic: darwin Running or building packages on Darwin label Feb 28, 2017
@LnL7 LnL7 merged commit f34c9d7 into NixOS:master Mar 1, 2017
@yurrriq yurrriq deleted the update/pkgs/applications/version-management/git-and-tools/gitflow branch March 6, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants