Skip to content

Commit

Permalink
qt5.qtwebengine: fix library paths
Browse files Browse the repository at this point in the history 
Without this it would try to find files in qtbase

Ported to Qt 5.8.
  • Loading branch information
@abbradar
abbradar committed Mar 21, 2017
1 parent 395af82 commit dec8fb0
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkgs/development/libraries/qt-5/5.8/qtwebengine/default.nix
View file
Expand Up @@ -35,6 +35,13 @@ qtSubmodule {
# fix default SSL bundle location
sed -i -e 's,/cert.pem,/certs/ca-bundle.crt,' src/3rdparty/chromium/third_party/boringssl/src/crypto/x509/x509_def.c
# Fix library paths
sed -i \
-e "s,QLibraryInfo::location(QLibraryInfo::DataPath),QLatin1String(\"$out\"),g" \
-e "s,QLibraryInfo::location(QLibraryInfo::TranslationsPath),QLatin1String(\"$out/translations\"),g" \
-e "s,QLibraryInfo::location(QLibraryInfo::LibraryExecutablesPath),QLatin1String(\"$out/libexec\"),g" \
src/core/web_engine_library_info.cpp
configureFlags+="\
-plugindir $out/lib/qt5/plugins \
-importdir $out/lib/qt5/imports \
Expand Down

3 comments on commit dec8fb0

@NickHu
Copy link
Contributor

@NickHu NickHu commented on dec8fb0 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me the following crash-on-run instead for qutebrowser --backend webengine:

 ❯ qutebrowser --backend webengine                                                      [15:24:49]
[30149:30195:0322/152453:FATAL:udev_loader.cc(38)] Check failed: false. 
#0 0x7f438285546e <unknown>
#1 0x7f438286960e <unknown>
#2 0x7f4384d0462f <unknown>
#3 0x7f4384d03919 <unknown>
#4 0x7f4384d0425c <unknown>
#5 0x7f4384a113aa <unknown>
#6 0x7f43828c165d <unknown>
#7 0x7f438286e61d <unknown>
#8 0x7f438286f24d <unknown>
#9 0x7f438286f52b <unknown>
#10 0x7f438284c920 <unknown>
#11 0x7f43828844c4 <unknown>
#12 0x7f438289a895 <unknown>
#13 0x7f4382ca05c8 <unknown>
#14 0x7f4382ca080d <unknown>
#15 0x7f438289abb4 <unknown>
#16 0x7f438289705d <unknown>
#17 0x7f43a2e32234 start_thread
#18 0x7f43a1d9e75f __GI___clone

[1]    30149 abort      qutebrowser --backend webengine

The QtWebKit backend still works fine.

@abbradar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's some another unrelated bug. I'll look at it later today.

@abbradar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a7a858a

Please sign in to comment.