Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigtalOcean backend: IPv6 support. #633

Merged
merged 1 commit into from Mar 29, 2017
Merged

DigtalOcean backend: IPv6 support. #633

merged 1 commit into from Mar 29, 2017

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Mar 21, 2017

Disabled by default, so it won't alter existing deployments.

@domenkozar
Copy link
Member

cc @teh

@teh
Copy link
Contributor

teh commented Mar 28, 2017

Apologies for the late response. Assuming this works (i.e. is tested) LGTM. The code looks fine.

I wonder about prefix_len, we have a similar function in the hetzner code but its so short I don't think it's worth factoring out just yet.

Thanks for implementing this!

@dhess
Copy link
Contributor Author

dhess commented Mar 28, 2017

I'm actively using it in my deployments. I tested both with and without the setting enabled.

@teh
Copy link
Contributor

teh commented Mar 29, 2017

@domenkozar can you merge?

@domenkozar domenkozar merged commit 55ceaa9 into NixOS:master Mar 29, 2017
@dhess dhess deleted the do-ipv6 branch March 29, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants