Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Rename addon id #2449

Merged
merged 2 commits into from Mar 21, 2017
Merged

Rename addon id #2449

merged 2 commits into from Mar 21, 2017

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Mar 21, 2017

No description provided.

@jaredhirsch jaredhirsch self-requested a review March 21, 2017 21:23
@@ -126,15 +122,15 @@ export_addon: addon
zip: addon
# FIXME: should remove web-ext-artifacts/*.zip first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just hit the bug this FIXME intends to fix (multiple zip files inside web-ext-artifacts causes mv to bail) :-P

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works, looks good

@jaredhirsch jaredhirsch merged commit b84c2e4 into master Mar 21, 2017
@jaredhirsch jaredhirsch deleted the rename-id branch March 21, 2017 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants