Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Rename everything to Screenshots #2378

Closed
22 of 24 tasks
ianb opened this issue Mar 14, 2017 · 4 comments
Closed
22 of 24 tasks

Rename everything to Screenshots #2378

ianb opened this issue Mar 14, 2017 · 4 comments
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Mar 14, 2017

We're going to be renaming the product to Firefox Screenshots. We'd like to rename everything.

Here's a basic proposal:

  • "Page Shot" is replaced with "Firefox Screenshots" or sometimes "Screenshots" (these are almost all readable text)
  • "shots" and "shot" does not get changed
  • This repo gets moved to https://github.com/mozilla-services/screenshots
  • In CSS classes the string "pageshots" can be removed: it was a form of namespacing that we don't really need. Except for pageshot-no-pointer-events
  • I'd like to move staging to screenshots.dev.mozaws.net and screenshots.stage.mozaws.net – we should open bugs for that, but can rename now, nothing is automated to make changing the code ahead of infrastructure a problem
  • The production domain will change from pageshot.net to screenshots.firefox.com
  • In most cases pageshot gets renamed to screenshots, except when it's some more global label, then we should use firefox-screenshots. E.g., the name in package.json
  • Addon ID changes to screenshots@mozilla.org
  • Icons could probably get a better name that doesn't include the product name
  • Dockerhub image gets renamed from mozilla/pageshot to mozilla/screenshots
  • I guess some of the environmental variables become SCREENSHOTS_*
  • We don't technically have to change repository URLs (github will redirect) but fixing everything makes it easier to grep
  • We rename the channel to #screenshots
  • (bug 1347304) We should look into renaming the Discourse groups
  • (screenshots-staff@mozilla.com) We could rename pageshot-staff
  • We could look through Google docs
  • Outreachy application
  • (https://wiki.mozilla.org/Firefox/Screenshots) wiki.mozilla.org
  • Rename pageshot-abuse and pageshot-feedback email aliases
  • Rename events (METRICS.md and code) ???
  • Review GitHub site description
  • Add logs.glob.uno logging of #screenshots
  • Make ops bots report to #screenshots (Bug 1349657)
  • Make GitHub bots report to #screenshots
@pdehaan
Copy link
Collaborator

pdehaan commented Mar 14, 2017

Are we doing any more Test Pilot releases before we ship in 54? It could be pretty confusing to rename the public discourse forums mid-release (unless we can do a redirect in the forums).

@pdehaan
Copy link
Collaborator

pdehaan commented Mar 15, 2017

Also, not sure how other people feel about this, but when we rename IRC channel, not sure if we would maybe also want to add a #screenshots-bots channel where we move all the automated bot chatter.

PROS: IRC will actually be usable for conversations/history.
CONS: One more channel to monitor (if you care about seeing all the bot comments and traffic).

@ianb ianb added this to the Sprint 54.2 milestone Mar 15, 2017
@ghost ghost modified the milestones: Sprint 54.2, Sprint 54.3 Mar 20, 2017
@jaredhirsch
Copy link
Member

FWIW, I prefer having the github bot chatter in the channel

@pdehaan
Copy link
Collaborator

pdehaan commented Mar 21, 2017

Current status: Looks like most of the remaining instances mostly URLs, IRC channels, some docs, etc.

$ git grep pageshot | grep -v "/pageshot[/.:]"

.ebextensions/00-environment.config:    value: pageshot.dev.mozaws.net
.ebextensions/00-environment.config:    value: pageshotcontent.dev.mozaws.net
.travis.yml:      - "irc.mozilla.org#pageshot"
README.md:There is an IRC channel `#pageshot` on irc.mozilla.org (you can use [this link](https://kiwiirc.com/client/irc.mozilla.org/pageshot) for chat access via the web if you do not otherwise use IRC).  There are [IRC logs available](http://logs.glob.uno/?c=pageshot).
addon/webextension/manifest.json.template:  "homepage_url": "https://github.com/mozilla-services/pageshot",
bin/release-version:    echo "Stage deployment automatically triggered, see #pageshot IRC for status"
circle.yml:    # we want firefox nightly in order to install an unsigned pageshot addon
docker-compose.yml:  image: pageshot
docs/METRICS.md:We will be tracking some events under `goto-pageshot` that would lead people from shot pages to a place where they could load the page.  Then we track clicking the install link itself, which GA reporting should be able to connect to the original `goto-pageshot` event.  We can't detect how often that install click leads to an actual install.
docs/METRICS.md:1. [x] Toggle shot button on `addon/start-shot/toolbar-button` (previous to 54 launch the label was `toolbar-pageshot-button`)
docs/METRICS.md:29. [x] Visit Screenshots link from footer `web/goto-homepage/footer` (was eventAction `goto-pageshot` before 54 launch)
docs/METRICS.md:5. [x] Click Screenshots link in header `web/goto-homepage/navbar` (was `goto-pageshot` eventAction before 54 launch)
docs/deployment.md:After it completes the stage deployment will automatically be triggered.  See the `#pageshot` IRC channel for status updates.
docs/docker.md:    docker run --net=host -e 'RDS_USERNAME=postgres' -e 'RDS_PASSWORD=********' -e 'RDS_HOSTNAME=pageshot-dev.czvvrkdqhklf.us-east-1.rds.amazonaws.com' -e 'SITE_ORIGIN=pageshotfzzzy.dev.mozaws.net' -e 'CONTENT_ORIGIN=pageshotcontentfzzzy.dev.mozaws.net' -e 'USE_S3=true' -e 'S3_BUCKET_NAME=pageshot-images-bucket' -e 'GA_ID=********' -e 'SENTRY_DSN=********' -e 'SENTRY_PUBLIC_DSN=********' fzzzy/pageshot
docs/testing-the-api.md:  "docTitle": "Screenshots erases everything in my clipboard · Issue #1237 · mozilla-services/pageshot",
server/src/config.js:    default: "pageshot-images-bucket",
server/src/footer-view.js:              <a href="https://github.com/mozilla-services/pageshot" target="_blank">GitHub</a>
server/src/pages/homepage/view.js:            <a href="https://github.com/mozilla-services/pageshot" target="_blank" className="link-icon github" title="GitHub"></a>
server/src/pages/shot/view.js:      // FIXME: consider twitter:site @mozillapageshot
server/src/server.js:      tests: "https://travis-ci.org/mozilla-services/pageshot"
server/src/server.js:      irc: "irc://irc.mozilla.org/#pageshot",

Disclaimer: I deleted the CHANGELOG.md file since that was particularly noisy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants