gmtp: init at 1.3.10 #24178
Merged
gmtp: init at 1.3.10 #24178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Mar 21, 2017
| meta = { | ||
| description = "A simple MP3 and Media player client for UNIX and UNIX like systems."; | ||
| homepage = "https://gmtp.sourceforge.io"; | ||
| platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
do you want to maintain this package?
There was a problem hiding this comment.
Thanks for taking time to review @Mic92 . I'm very new to nix / NixOS but would happy to maintain the package best I can.
There was a problem hiding this comment.
ok, in this case make a new entry in lib/maintainers.nix and yourself as a maintainer to this package:
meta = {
# ..
maintainers = with maintainers; [pbogdan];
}
There was a problem hiding this comment.
Done, will squash the commits once everything looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gmtp is currently not present in nixpkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This is my first time adding a package so any feedback would be appreciated.