Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armadillo: 7.700.0 -> 7.800.1 #23736

Merged
merged 1 commit into from Mar 19, 2017
Merged

armadillo: 7.700.0 -> 7.800.1 #23736

merged 1 commit into from Mar 19, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 11, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @knedlsepp to be a potential reviewer.

@knedlsepp
Copy link
Member

Two minor points:

@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017

Fixed

@ndowens ndowens changed the title armadillo: 7.200.2 -> 7.800.1 armadillo: 7.700.0 -> 7.800.1 Mar 11, 2017
@knedlsepp
Copy link
Member

knedlsepp commented Mar 13, 2017 •
edited

I think you might have accidentally removed the actual update to 7.800.1

@ndowens
Copy link
Contributor Author

ndowens commented Mar 13, 2017

Ahh crap lol will fix

@ndowens
armadillo: 7.700.0 -> 7.800.0
f3dab1a 
armadillo: Added forgotton version update
@ndowens
Copy link
Contributor Author

ndowens commented Mar 13, 2017

Fixed

@ndowens ndowens merged commit e2be606 into NixOS:master Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndowens @mention-bot @knedlsepp @matthiasbeyer @joachifm