Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcachegrind: init at 16.2.2 #23766

Merged
merged 1 commit into from Mar 12, 2017
Merged

kcachegrind: init at 16.2.2 #23766

merged 1 commit into from Mar 12, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Mar 11, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@orivej, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer.

@orivej orivej mentioned this pull request Mar 11, 2017
Closed
7 tasks
@periklis
Copy link
Contributor

fyi, i am working on a similar PR for qcachegrind to make it available for macos users too.

vcunat
vcunat approved these changes Mar 12, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work OK; probably the same version as old kde4.kcachegrind but built against newer libs.

@ttuegel ttuegel merged commit 28e78fd into NixOS:master Mar 12, 2017
vcunat pushed a commit that referenced this pull request Mar 12, 2017
@vcunat
Merge pull request #23766 from orivej/kcachegrind-kdelibs
b45aee4 
kcachegrind: init at 16.2.2

(cherry picked from commit 28e78fd)
It's just adding a new package (back).
@vcunat
Copy link
Member

vcunat commented Mar 12, 2017

For reference, also picked to 17.03.

@orivej orivej deleted the kcachegrind-kdelibs branch March 12, 2017 18:49
@orivej
Copy link
Contributor Author

orivej commented Mar 12, 2017

Thanks!
@periklis You may add me to the pull request and as a maintainer of qcachegrind.

@periklis periklis mentioned this pull request Mar 12, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orivej @mention-bot @periklis @vcunat @joachifm @ttuegel