Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electrum 2 8 #23751

Merged
merged 4 commits into from Mar 11, 2017
Merged

Electrum 2 8 #23751

merged 4 commits into from Mar 11, 2017

Conversation

joachifm
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehmry, @FRidh and @np to be potential reviewers.

@ehmry
Copy link
Contributor

ehmry commented Mar 11, 2017

It can't open my wallet file, but other that, it works.

Traceback (most recent call last):
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum_gui/qt/__init__.py", line 157, in start_new_window
    wallet = self.daemon.load_wallet(path, None)
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/daemon.py", line 220, in load_wallet
    wallet = Wallet(storage)
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/wallet.py", line 1751, in __new__
    wallet = WalletClass(storage)
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/wallet.py", line 1563, in __init__
    Deterministic_Wallet.__init__(self, storage)
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/wallet.py", line 1408, in __init__
    Abstract_Wallet.__init__(self, storage)
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/wallet.py", line 105, in __init__
    self.load_addresses()
  File "/nix/store/bcqgm3iak715kqpz1hkz1p2g44hg1g93-electrum-2.8.0/lib/python2.7/site-packages/electrum/wallet.py", line 223, in load_addresses
    self.receiving_addresses = d.get('receiving', [])
AttributeError: 'list' object has no attribute 'get'

@joachifm
Copy link
Contributor Author

@ehmry hm, I don't see anything in the changelog about incompatibilities with older wallets. Looks like a bug to me or at least a deficiency.

@joachifm
Copy link
Contributor Author

Looks related: spesmilo/electrum@0e49274. I'll wait until 2.8.1 hits the release archives.

@joachifm
Copy link
Contributor Author

Hrm, maybe not. I'll wait anyway.

@joachifm
Copy link
Contributor Author

@ehmry could you try again with 2.8.1? I don't have any old wallets handy, but I was at least able to open a freshly wallet created with 2.7.18.

@ehmry
Copy link
Contributor

ehmry commented Mar 11, 2017

Excellent, no problems with 2.8.1, I say merge.

@joachifm
pythonPackages.trezor: 0.7.4 -> 0.7.12
10a0f1c
@joachifm
pythonPackages.mnemonic: 0.12 -> 0.17
9cc2083
@joachifm
pythonPackages.pyaes: init at 1.6.0
617d8af
@joachifm
electrum: 2.7.18 -> 2.8.1
d575efc 
See https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

Also
- patch .desktop file to include full path to electrum
- add dep on pysocks
- remove dep on pyasn; per the changelog, it has not been used since v2.1
- replace dep on slowaes with pyaes
@joachifm joachifm merged commit 89e4618 into NixOS:master Mar 11, 2017
@joachifm joachifm deleted the electrum-2_8 branch March 11, 2017 19:02
@joachifm
Copy link
Contributor Author

@ehmry cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joachifm @mention-bot @ehmry