Skip to content

Commit

Permalink
Revert "Merge pull request #23602 from periklis/topic_qt57_darwin"
Browse files Browse the repository at this point in the history
This reverts commit 4c0737e, reversing
changes made to 943c4ed.
  • Loading branch information
LnL7 committed Mar 10, 2017
1 parent 77c4979 commit a2eae3b
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 479 deletions.
4 changes: 2 additions & 2 deletions pkgs/development/libraries/qt-5/5.7/default.nix
Expand Up @@ -107,12 +107,12 @@ let
makeQtWrapper =
makeSetupHook
{ deps = [ makeWrapper ]; }
(if stdenv.isDarwin then ../make-qt-wrapper-darwin.sh else ../make-qt-wrapper.sh);
../make-qt-wrapper.sh;

qmakeHook =
makeSetupHook
{ deps = [ self.qtbase.dev ]; }
(if stdenv.isDarwin then ../qmake-hook-darwin.sh else ../qmake-hook.sh);
../qmake-hook.sh;

};

Expand Down

3 comments on commit a2eae3b

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LnL7: Don't forget that commit messages should explain the why in addition to the what. (It's impossible to know why this was reverted.)

https://chris.beams.io/posts/git-commit/#why-not-how

@LnL7
Copy link
Member Author

@LnL7 LnL7 commented on a2eae3b Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the PR, should have added something in the message. qtbase57 started failing after on linux.

@periklis
Copy link
Contributor

@periklis periklis commented on a2eae3b Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a re-revert incl. buildInputs fix #23764. Need help with a hydra-jobset for this PR on linux. Thanks in advance.

Please sign in to comment.