You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2eae3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LnL7: Don't forget that commit messages should explain the why in addition to the what. (It's impossible to know why this was reverted.)
https://chris.beams.io/posts/git-commit/#why-not-how
a2eae3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on the PR, should have added something in the message.
qtbase57
started failing after on linux.a2eae3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a re-revert incl. buildInputs fix #23764. Need help with a hydra-jobset for this PR on linux. Thanks in advance.