krfb: expose kde 5 version #23755
Merged
krfb: expose kde 5 version #23755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer. |
ttuegel
requested changes
Mar 11, 2017
| kdeApp { | ||
| name = "krfb"; | ||
| meta = { | ||
| license = with lib.licenses; [ gpl2 fdl12 ]; |
There was a problem hiding this comment.
Please add yourself to meta.maintainers!
|
Heh, I had originally written the log as "init at ...", but then I figured that wasn't right since it had already been present in the kde 4 tree. Ah well! :) Both changes made. |
ttuegel
approved these changes
Mar 12, 2017
Well, it's tricky, because I already removed the KDE 4 version! But I see your point. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)