Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashpay: 0.12.055 -> 0.12.1.3 #23761

Merged
merged 1 commit into from Mar 19, 2017
Merged

dashpay: 0.12.055 -> 0.12.1.3 #23761

merged 1 commit into from Mar 19, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 11, 2017

dashpay: fixed mistype

Motivation for this change

Update & lost copy of repo

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @AndersonTorres and @dezgeg to be potential reviewers.

@ndowens ndowens mentioned this pull request Mar 11, 2017
Closed
7 tasks
@vcunat
Copy link
Member

vcunat commented Mar 11, 2017

For me the build fails with:

[...]
  CXX      qt/qt_libbitcoinqt_a-coincontroldialog.o
  CXX      qt/qt_libbitcoinqt_a-coincontroltreewidget.o
  CXX      qt/qt_libbitcoinqt_a-darksendconfig.o
  CXX      qt/qt_libbitcoinqt_a-editaddressdialog.o
  CXX      qt/qt_libbitcoinqt_a-masternodelist.o
  CXX      qt/qt_libbitcoinqt_a-openuridialog.o
  CXX      qt/qt_libbitcoinqt_a-overviewpage.o
  CXX      qt/qt_libbitcoinqt_a-paymentrequestplus.o
  CXX      qt/qt_libbitcoinqt_a-paymentserver.o
  CXX      qt/qt_libbitcoinqt_a-receivecoinsdialog.o
  CXX      qt/qt_libbitcoinqt_a-receiverequestdialog.o
qt/masternodelist.cpp: In member function 'void MasternodeList::updateMyMasternodeInfo(QString, QString, masternode_info_t&)':
qt/masternodelist.cpp:193:172: error: 'class QDateTime' has no member named 'offsetFromUtc'
                                                                                                    infoMn.fInfoValid ? infoMn.nTimeLastPing + QD
ateTime::currentDateTime().offsetFromUtc() : 0)));
                                                                                                                                                 
                           ^
qt/masternodelist.cpp: In member function 'void MasternodeList::updateNodeList()':
qt/masternodelist.cpp:276:173: error: 'class QDateTime' has no member named 'offsetFromUtc'
         QTableWidgetItem *lastSeenItem = new QTableWidgetItem(QString::fromStdString(DateTimeStrFormat("%Y-%m-%d %H:%M", mn.lastPing.sigTime + QDateTime::currentDateTime().offsetFromUtc())));
                                                                                                                                                                             ^
At global scope:
cc1plus: warning: unrecognized command line option '-Wno-self-assign'
make[2]: *** [Makefile:6836: qt/qt_libbitcoinqt_a-masternodelist.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/tmp/nix-build-dashpay-0.12.1.3.drv-0/dash-v0.12.1.3-src/src'
make[1]: *** [Makefile:9027: all-recursive] Error 1
make[1]: Leaving directory '/tmp/nix-build-dashpay-0.12.1.3.drv-0/dash-v0.12.1.3-src/src'
make: *** [Makefile:651: all-recursive] Error 1
builder for ‘/nix/store/zy6phsayp6f3qsnrzx9sqk9ihyng4j3a-dashpay-0.12.1.3.drv’ failed with exit code 2

I added enableParallelBuilding = true; to decrease the wait, but the failure doesn't seem like a parallel-make problem.

@vcunat
Copy link
Member

vcunat commented Mar 11, 2017

BTW, generally it would be nice to phase-out qt4 during 2017, but that's nothing important, really. (Certainly not a blocker for this PR.)

@vcunat
Copy link
Member

vcunat commented Mar 11, 2017

The same error happens without enableParallelBuilding.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017

I tried to camelCase with_Gui and others and now i get undefined variable with_gui even though they are all with_Gui now instead of lowercase version

@vcunat
Copy link
Member

vcunat commented Mar 11, 2017

That sounds like some trivial oversight/typo. You're right that camelCase would be more idiomatic.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017

I used vim search and none of them are with_gui, all are with_Gui

@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017

Though the error comes from nox-review wip, but not from nix-build -A altcoins.dashpay

@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017 •
edited

On the build issue, gonna have to get with author(s)

Though I am thinking it might be a qt4 compile issue; trying with qt3

Update: qt3 doesn't want to even try at all. I think that I may have to take the gui option completely out

@ndowens
dashpay: 0.12.055 -> 0.12.1.3
cd62bb6 
dashpay: fixed mistype

dashpay: Cosmetic change; camelCase

dashpay: removed gui option, causes build issue

dashpay: cmake flag issue fixed
@ndowens
Copy link
Contributor Author

ndowens commented Mar 11, 2017

@vcunat works now, with gui disabled.

@vcunat vcunat merged commit 736ee61 into NixOS:master Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndowens @mention-bot @vcunat @joachifm