debian-patches.sh: clean up maintainer script #23759
Conversation
Set correct interpreter, fix quoting
|
Looks like the tracker url was replaced by: https://tracker.debian.org/pkg/patch |
| @@ -1,17 +1,17 @@ | |||
| #!/bin/sh | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
I think right now our setup is to have mandatory /bin/sh but optional /ur/bin/env
There was a problem hiding this comment.
The shell script uses features outside of POSIX sh. Specifically, these are bash features.
| url="${prefix}/${deb_patches[$i]}" | ||
| sha256=$(nix-prefetch-url $url) | ||
| echo " {" | ||
| url=${prefix}/${deb_patches[$i]} |
There was a problem hiding this comment.
Because the quotes are redundant.
| echo " url = \"\${prefix}/${deb_patches[$i]}\";" | ||
| echo " sha256 = \"$sha256\";" | ||
| echo " }" | ||
| echo ' }' |
There was a problem hiding this comment.
Why would you want to change the quote type here?
There was a problem hiding this comment.
Because it's a constant.
|
I am not a fitting reviewer for these changes, I find the result harder to read. Some non-purely-cosmetical catches are useful, though. Convenient GitHub interface doesn't let me to dismiss my change request as obsolete… |
Set correct interpreter, fix quoting
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)