Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evolution: Delete invalid option #23747

Merged
merged 1 commit into from Mar 16, 2017
Merged

evolution: Delete invalid option #23747

merged 1 commit into from Mar 16, 2017

Conversation

butterflya
Copy link
Contributor

Motivation for this change

The removed configureFlags entry is not a documented option according to configure --help.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The removed configureFlags entry is not a documented option according to `configure --help`.
@mention-bot
Copy link

@butterflya, thanks for your PR! By analyzing the history of the files in this pull request, we identified @groxxda and @edolstra to be potential reviewers.

@joachifm joachifm changed the title Delete invalid option evolution: Delete invalid option Mar 11, 2017
@joachifm
Copy link
Contributor

joachifm commented Mar 11, 2017

Please always indicate what component the change applies to, for the benefit of people scanning for PRs they might care to look at and for better history :)

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evolution's configure script also barfs

configure: WARNING: unrecognized options: --disable-spamassassin

@Mic92 Mic92 merged commit f940d9f into NixOS:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants