Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lzip: 1.17 -> 1.18 #23426

Merged
merged 1 commit into from Mar 18, 2017
Merged

lzip: 1.17 -> 1.18 #23426

merged 1 commit into from Mar 18, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 3, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @peti and @Phreedom to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Mar 6, 2017

This is a fairly hefty rebuild

@ndowens
Copy link
Contributor Author

ndowens commented Mar 6, 2017

Weird that none of the builds succeeded through travis, but it did on my system

@joachifm
Copy link
Contributor

joachifm commented Mar 6, 2017

lzip itself is a small build, but it has lots of reverse dependencies.

@matthiasbeyer
Copy link
Contributor

@joachifm care to tag it "mass-rebuild", then?

vcunat added a commit to vcunat/nixpkgs that referenced this pull request Mar 7, 2017
@vcunat
Copy link
Member

vcunat commented Mar 7, 2017

Staged. (GitHub will close on merging to master.)

@FRidh FRidh merged commit c00aa5d into NixOS:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants