ttylog: 0.26 -> 0.29 #23417
Closed
ttylog: 0.26 -> 0.29 #23417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington and @nckx to be potential reviewers. |
nckx
reviewed
Mar 3, 2017
|
|
||
| src = fetchFromGitHub { | ||
| owner = "rocasa"; | ||
| repo = "ttylog"; | ||
| rev = version; | ||
| sha256 = "1xvqch1dwpl2d89n9cjcxhqbpvm50fspj5yn883wbii6dpg62p84"; | ||
| rev = "${version}"; |
|
If you are referring to the version. It's personal preference. I always bracket variables
…Sent from my iphone
On Mar 2, 2017, 7:13 PM -0600, Tobias Geerinckx-Rice ***@***.***>, wrote:
@nckx commented on this pull request.
In pkgs/tools/misc/ttylog/default.nix (#23417 (comment)):
> src = fetchFromGitHub { owner = "rocasa"; repo = "ttylog"; - rev = version; - sha256 = "1xvqch1dwpl2d89n9cjcxhqbpvm50fspj5yn883wbii6dpg62p84"; + rev = "${version}";
Why this change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23417 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL73H5uns2WvZZbAPd2UAJfGEftjc8ks5rh2kdgaJpZM4MRvVh).
|
|
Applied in 55e3760, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)