llvm: 4.0rc2 -> 4rc3 #23408
Merged
llvm: 4.0rc2 -> 4rc3 #23408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add myself to maintainers for LLVM.
This reflects upstream versioning change, and allows us to replace 4.0 with 4.1 (which is now a minor revision) without changing the attribute name. Thanks to @vcunat for the idea.
vcunat
added a commit
to vcunat/nixpkgs
that referenced
this pull request
Mar 3, 2017
and rename attributes 4.0 -> 4
vcunat
added a commit
that referenced
this pull request
Mar 3, 2017
and rename attributes 4.0 -> 4 (cherry picked from commit 92f454e)
|
Thank you for being on top of this! This is one reason I love NixOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
LLVM published 4.0rc3 today, this updates us from rc2.
Also incorporates an idea from the rc2 PR and shortens the version to reflect the new versioning scheme used.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)