Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libchop: fix package #23430

Merged
merged 1 commit into from Mar 4, 2017
Merged

libchop: fix package #23430

merged 1 commit into from Mar 4, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 3, 2017

Motivation for this change

See #23418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @7c6f434c to be potential reviewers.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 4, 2017

Merge?

@7c6f434c 7c6f434c merged commit 3f817d0 into NixOS:master Mar 4, 2017
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 5, 2017

@7c6f434c Can you port this to release-17.03 as well?

@vcunat
Copy link
Member

vcunat commented Mar 5, 2017 •
edited

Done as 29332b4.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 5, 2017

Thanks!

@rnhmjoj rnhmjoj deleted the libchop branch September 12, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @mention-bot @vcunat @7c6f434c