Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode #23410

Closed
wants to merge 3 commits into from
Closed

Update vscode #23410

wants to merge 3 commits into from

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Mar 2, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@xwvvvvwx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @uralbash, @jansuchomel and @mucaho to be potential reviewers.

@d-xo
Copy link
Contributor Author

d-xo commented Mar 2, 2017

Every time I update this package, I have to do the exact same steps every single time. So I wrote a script to automate most of this (it just prints out the various bits of the derivation that need to change), and checked it in as part of this PR.

Is this OK?

@jansuchomel
Copy link
Contributor

The license should remain unfree as the binary version is distributed under EULA.

@d-xo
Copy link
Contributor Author

d-xo commented Mar 4, 2017

Hey, I don't know much about licenses, so more than happy to back out the change, but would really appreciate some more detail.

When I go to the GitHub page it says MIT, what exactly makes this package unfree?

@fpletz
Copy link
Member

fpletz commented Mar 4, 2017

The source is MIT licensed but the pre-built binary from Microsoft that we are using falls under the "MICROSOFT SOFTWARE LICENSE TERMS". It specifically states that "You may not [..] share, publish, or lend the software [..] to any third party", thus making it unfree.

We would have to compile it from source ourselves to create a binary we can distribute freely.

@3noch
Copy link
Contributor

3noch commented Mar 31, 2017

VS Code is currently at 1.10.2 so this PR would be downgrading. Can it be closed?

@d-xo d-xo closed this Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants