Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanmem: 0.15.6 -> 0.16 #23424

Closed
wants to merge 1 commit into from
Closed

scanmem: 0.15.6 -> 0.16 #23424

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 3, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Chattered and @mbakke to be potential reviewers.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 5, 2017

Pushed to master (cc9b960).

I see that v0.15.7 had some security fixes, but the latest version has some known issues: https://github.com/scanmem/scanmem/releases. I don't use scanmem and I didn't look into what these known issues are.

Thoughts on backporting to release-17.03?

@bjornfor bjornfor closed this Mar 5, 2017
@ghost
Copy link

ghost commented Mar 5, 2017

They appear to be minor annoyances and aesthetic issues with the GUI. I've only ever used scanmem from the CLI, so I'm not sure how irritating they would be, but I'd like to keep to the latest version which has some nice additional features.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2017

Applied to release-16.09 (01b9990) and release-17.03 (ee0e856) as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants