fcron-module: Add fcron user. Fixes #23320 #23413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Mar 3, 2017
| @@ -105,6 +105,10 @@ in | |||
| ]; | |||
|
|
|||
| environment.systemPackages = [ pkgs.fcron ]; | |||
| users.extraUsers.fcron = { | |||
| isNormalUser = true; | |||
There was a problem hiding this comment.
Why does it need to be a normal user?
|
Would think it would be safer and package fails to compile ifbuser is set to root
…Sent from my iphone
On Mar 3, 2017, 9:19 AM -0600, Joachim F. ***@***.***>, wrote:
@joachifm commented on this pull request.
In nixos/modules/services/scheduling/fcron.nix (#23413 (comment)):
> @@ -105,6 +105,10 @@ in ]; environment.systemPackages = [ pkgs.fcron ]; + users.extraUsers.fcron = { + isNormalUser = true;
Why does it need to be a normal user?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23413 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7_KuGGn6_pjdyZf7Oh56xMf-UH70ks5riC-YgaJpZM4MRtou).
|
|
Safer than what? Daemon users are typically added as system users, not ordinary logins. |
|
I mean I would think it would be safer to run as user than root. I set the package to run as user too instead of root
…Sent from my iphone
On Mar 3, 2017, 9:54 AM -0600, Joachim F. ***@***.***>, wrote:
Safer than what? Daemon users are typically added as system users, not ordinary logins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23413 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL76mpJUCTBo7PzXjW9q07YXU3sjWUks5riDfRgaJpZM4MRtou).
|
|
Sure, but please use |
|
Ah didn know that exist d. Will fix when I can, sometime today I suspect
…Sent from my iphone
On Mar 3, 2017, 9:57 AM -0600, Joachim F. ***@***.***>, wrote:
Sure, but please use isSystemUser for daemon accounts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23413 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7wwpb2SiNlStfDB-TK7aLAEnVOmDks5riDhtgaJpZM4MRtou).
|
fcron-mod: changed isNormalUser to isSystemUser
|
Fixed
…Sent from my iphone
On Mar 3, 2017, 9:57 AM -0600, Joachim F. ***@***.***>, wrote:
Sure, but please use isSystemUser for daemon accounts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23413 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7wwpb2SiNlStfDB-TK7aLAEnVOmDks5riDhtgaJpZM4MRtou).
|
Mic92
added a commit
that referenced
this pull request
Mar 5, 2017
|
fixed by 947815f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add fcron user
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)