Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak_cs: added authv4 support and fixed advanced.conf #23293

Closed
wants to merge 1 commit into from
Closed

riak_cs: added authv4 support and fixed advanced.conf #23293

wants to merge 1 commit into from

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Feb 28, 2017

Motivation for this change
  1. Auth V4 should be supported within the Riak CS package
  2. /etc/riak-cs/advanced.conf should be auto-filled to disable possible breaks within the Riak CS launch. Error is thrown with empty /etc/riak-cs/advanced.conf file.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -110,13 +118,6 @@ in
'';
};

extraAdvancedConfig = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option no longer required? Do you already cover all options in riak-cs/advanced.config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed, because all options except for key_perm and cert_perm can be covered in the other configuration file (riak-cs.conf). The advanced.conf was a relic from Riak CS 1.x (mentioned in their docs) and is currently being replaced by riak-cs.conf. The only options that riak-cs.conf can't cover are the ones implemented in the options provided here and key_perm and cert_perm. key_perm and cert_perm are coming in another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, advanced.conf can be a liability to breaking the package functionality: a malformed advanced.conf will prevent the package from booting.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2018

@mdaiter ping? Do we merge this?

@c0bw3b c0bw3b self-assigned this Oct 14, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

Stalled

@c0bw3b c0bw3b closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants