proselint: init at 0.8.0 #23283
Merged
proselint: init at 0.8.0 #23283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alibabzo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
| version = "0.8.0"; | ||
|
|
||
| src = fetchurl { | ||
| url = "mirror://pypi/s/proselint/${name}.tar.gz"; |
There was a problem hiding this comment.
I get a 404 error with this URL. Should this be
mirror://pypi/p/proselint/${name}.tar.gz
instead? (Replace /s/ with /p/)
FRidh
reviewed
Mar 18, 2017
| @@ -18901,6 +18901,8 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| proselint = callPackage ../tools/text/proselint { }; | |||
There was a problem hiding this comment.
@7c6f434c thanks for checking old PR's.
@alibabzo if this is an application, then it shouldn't be called via python-packages.nix but directly from all-packages.nix.
There was a problem hiding this comment.
As this is already merged, would you like me to create another pull request? I don't seem to be able to submit further revisions on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)