Link "Read revision" buttons in reports page. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add redirect using revision id to review/rev page and add links of revision buttons in reports page.
ferbncode
changed the title
gentlecat
suggested changes
Mar 6, 2017
| @@ -90,6 +90,10 @@ def entity(id, rev=None): | |||
| other_reviews = user_all_reviews[:3] | |||
| return render_template('review/entity/%s.html' % review.entity_type, review=review, spotify_mappings=spotify_mappings, soundcloud_url=soundcloud_url, vote=vote, other_reviews=other_reviews) | |||
|
|
|||
| @review_bp.route('/<uuid:id>/revision/<int:rev_id>') | |||
| def redirect_to_entity(id, rev_id): | |||
There was a problem hiding this comment.
rev_id can be interpreted as "review id" or "revision id". It's better to make both arguments explicit: review_id, revision_id.
| @@ -90,6 +90,10 @@ def entity(id, rev=None): | |||
| other_reviews = user_all_reviews[:3] | |||
| return render_template('review/entity/%s.html' % review.entity_type, review=review, spotify_mappings=spotify_mappings, soundcloud_url=soundcloud_url, vote=vote, other_reviews=other_reviews) | |||
|
|
|||
| @review_bp.route('/<uuid:id>/revision/<int:rev_id>') | |||
| def redirect_to_entity(id, rev_id): | |||
| rev_num = db_revision.get_revision_number(id, rev_id) | |||
There was a problem hiding this comment.
It's probably a good idea to catch NoDataFoundException in case revision is not found.
critiquebrainz/db/revision.py
Outdated
| id | ||
| FROM revision | ||
| WHERE review_id = :review_id) | ||
| AS indexedrevisions |
There was a problem hiding this comment.
Small nitpick. I think it will look a bit better like this:
FROM (
SELECT row_number() over(order by timestamp),
id
FROM revision
WHERE review_id = :review_id
) AS indexed_revisions
WHERE id = :revision_id:)
Indentation fixes, proper args usage in redirect_to_entity view and catch exception in view for redirect function.
gentlecat
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add redirect using
revision idtoreview/revisions/revpage and add links ofrevisionbuttons inreport_resultspage.