Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s6-portable-utils: 2.0.5.3 -> 2.1.0.0 #23543

Merged
merged 7 commits into from Mar 18, 2017
Merged

s6-portable-utils: 2.0.5.3 -> 2.1.0.0 #23543

merged 7 commits into from Mar 18, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 5, 2017

Motivation for this change

Added gcc for darwin Support; Could not update PR #23425; Tried hard to do so, but my local branch the PR was using seems to be gone; Did a git fetch pull/#/head:branch; edited the file after checkout-ing the branch and didn't work

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pmahoney, @peti and @pSub to be potential reviewers.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 6, 2017

Sorry about the commits, I couldn't rebase to shrink them

@Mic92 Mic92 added the 6.topic: darwin Running or building packages on Darwin label Mar 6, 2017
@7c6f434c 7c6f434c merged commit 7bbf7cb into NixOS:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (update)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants