Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dvdstyler: init at 3.0.3 #23536

Closed
wants to merge 2 commits into from
Closed

Dvdstyler: init at 3.0.3 #23536

wants to merge 2 commits into from

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 5, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

maintainers = [ maintainers.AndersonTorres ];
platforms = platforms.linux;
license = with licenses; gpl2;
maintainers = with maintainers [ AndersonTorres ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

maintainers = with maintainers; [ AndersonTorres ];

instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have noted it later during my regular work. Many thanks for the corrections!

@Mic92
Copy link
Member

Mic92 commented Mar 6, 2017

Merged in 9ef30ce

@Mic92 Mic92 closed this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants