bluez: also install gatttools #23540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
reviewed
Mar 5, 2017
| @@ -22,7 +22,7 @@ in stdenv.mkDerivation rec { | |||
| readline libsndfile udev libical | |||
| # Disables GStreamer; not clear what it gains us other than a | |||
| # zillion extra dependencies. | |||
| # gstreamer gst-plugins-base | |||
| # gstreamer gst_plugins_base | |||
There was a problem hiding this comment.
Or "leave it unchanged" is what I mean.
Mic92
reviewed
Mar 5, 2017
| @@ -51,6 +51,7 @@ in stdenv.mkDerivation rec { | |||
| # FIXME: Move these into a separate package to prevent Bluez from | |||
| # depending on Python etc. | |||
| postInstall = '' | |||
| cp ./attrib/gatttool $out/bin/gatttool | |||
There was a problem hiding this comment.
the version of bluez you are currently modifying is only used by libreoffice. Is this indented? Otherwise there is bluez5.nix in the same directory
|
OK, I assume that was unintentional and push the version changing actual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
third attempt. sorry I don't know how to github.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)