drbd: fix output file location #23541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbd was installing files into $out/nix/store/... due to the usage of DESTDIR (setting both DESTDIR + prefix to $out will cause files to be installed into $out/$out/...)
|
@bennofs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @wkennington to be potential reviewers. |
|
The package is also very old: 9.06 is the current version: https://www.drbd.org/en/community/download |
|
I expect this fixes #21051 |
|
@joachifm yes it should. as I said, I don't actually use |
|
@bennofs me neither; I think that if the resulting output at least has the correct layout, it has to be better than what is already in the tree. |
globin
pushed a commit
that referenced
this pull request
Mar 20, 2017
drbd was installing files into $out/nix/store/... due to the usage of DESTDIR (setting both DESTDIR + prefix to $out will cause files to be installed into $out/$out/...) (cherry picked from commit 8c0074d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drbd was installing files into $out/nix/store/... due to the usage of DESTDIR
(setting both DESTDIR + prefix to $out will cause files to be installed into $out/$out/...)
I'm unfortunately not very familar with this package, so I don't know how to properly test my changes.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)