Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flacon: 2.0.1 -> 2.1.1 #23529

Closed
wants to merge 1 commit into from
Closed

flacon: 2.0.1 -> 2.1.1 #23529

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 5, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2017

Flacon segfaults on my machine, when trying to open a file (File -> Add File)

$ flacon
** (flacon:32274): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
(flacon:32274): GLib-GIO-ERROR **: No GSettings schemas are installed on the system
Trace/breakpoint trap

@ndowens
Copy link
Contributor Author

ndowens commented Mar 5, 2017

@Mic92 weird, i just went to file, add file and it didnt crash on me at all

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2017

Probably some environment variable is not set to make Gsettings working correctly while you are using a Desktop environment such as Gnome.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 5, 2017 via email

@ndowens
flacon: 2.0.1 -> 2.1.1
f1d7e11 
Added gsettings_desktop_schemas to buildInputs to fix a luanch error
@ndowens
Copy link
Contributor Author

ndowens commented Mar 6, 2017

@Mic92 I added gsettings schemes; I got that inital error on startup but adding a file didn't cause a segfault for me, so maybe this will fix it

@Mic92 Mic92 closed this in 4ae0e8c Mar 6, 2017
Mic92 pushed a commit that referenced this pull request Mar 6, 2017
@ndowens @Mic92
flacon: 2.0.1 -> 2.1.1
6c2e255 
fixes #23529

(cherry picked from commit 4ae0e8c)
@Mic92
Copy link
Member

Mic92 commented Mar 6, 2017

I had to point XDG_DATA_DIRS to gtk3 to make it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndowens @Mic92 @matthiasbeyer