Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim plugins #23513

Closed
wants to merge 4 commits into from
Closed

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Some vim plugins I had in my configuration.nix, but never put into nixpkgs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jagajaga, @LnL7 and @garbas to be potential reviewers.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 5, 2017

@matthiasbeyer: I noticed that none of these plugins have a version number (date). Also, it seems that most plugins these days are simply listed in pkgs/misc/vim-plugins/vim-plugin-names and then autogenerated from that. See comment in top of pkgs/misc/vim-plugins/default.nix. Perhaps use this workflow?

@jagajaga
Copy link
Member

jagajaga commented Mar 5, 2017

Please properly generate plugins with vim2nix and add also them to a list for autogeneration.

@matthiasbeyer
Copy link
Contributor Author

In the process of doing this right now...

@matthiasbeyer
Copy link
Contributor Author

This takes ridiculous long, I don't care enough.

@matthiasbeyer matthiasbeyer deleted the add-vim-plugins branch March 5, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants