hack module to allow OpenGL::Image to seamlessly use OpenGL::Modern #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchristian
force-pushed
the
image_hack
branch
2 times, most recently
from
d0b546b
to
b12905b
Compare
|
Seems reasonable. Maybe it make sense to add :constants to OpenGL::Modern? |
|
For backwards compatibility, absolutely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this yesterday and here it is. It is exceedingly simple.
It sets up a fake OpenGL namespace and blocks the %INC entry so it won't be overloaded by the real OpenGL.pm. Then it installs a barebones import method that simply rewrites it into an import on OpenGL::Modern, executed in the namespace of the caller. That way any import calls to the OpenGL namespace result in the import being done from OpenGL::Modern into the caller.
Only niggle is that OpenGL::Modern has no :constants, so i had to munge that into :all.
What do you think?