Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove indention from program listings #23512

Merged
merged 4 commits into from Mar 6, 2017

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

xfce documentation has weird code listing indentions... so fix it...

@mention-bot
Copy link

@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat and @grahamc to be potential reviewers.

@matthiasbeyer
Copy link
Contributor Author

Added some more fixes to the section.

I really hate that I cannot have a markdown file here... 😢

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the couple places I've identified. Docbook is what we've got, and isn't so bad :)

</programlisting>

This is caused by some needed GNOME services not running.
This is all fixed by enabling "Launch GNOME services on startup" in
the Advanced tab of the Session and Startup settings panel.
Alternatively, you can run this command to do the same thing.
<programlisting>
$ xfconf-query -c xfce4-session -p /compat/LaunchGNOME -s true
xfconf-query -c xfce4-session -p /compat/LaunchGNOME -s true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to have a leading $.

@@ -87,15 +87,15 @@
(look at journalctl --user -b).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, can you wrap journalctl --user -b in <command> / </command>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@grahamc grahamc merged commit 0705346 into NixOS:master Mar 6, 2017
@matthiasbeyer matthiasbeyer deleted the doc-fix-xfce branch March 7, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants