phpfpm: eliminate build at evaluation time #23216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fkz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @ericsagnes and @bluescreen303 to be potential reviewers. |
joachifm
reviewed
Feb 26, 2017
| ${cfg.phpOptions} | ||
| ''; | ||
|
|
||
| phpIni = pkgs.stdenv.mkDerivation { |
There was a problem hiding this comment.
Alternatively, some variaton of
pkgs.runCommand "php.ini" { inherit (cfg) phpPackage phpOptions; } ''
cat $phpPackage/etc/php.ini > $out
echo $phpOptions >> $out
''
There was a problem hiding this comment.
You can use passAsFile:
pkgs.runCommand "php.ini" { inherit (cfg) phpPackage phpOptions; passAsFile = [ "phpOptions" ]; } ''
cat $phpPackage/etc/php.ini $phpOptionsFile > $out
''
phpfpm currently uses `readFile` to read the php.ini file from the phpPackage. This causes php to be build at evaluation time. This eliminates the use of readFile and builds the php.ini at build time.
fpletz
approved these changes
Feb 26, 2017
|
This has broken php.ini customizations via |
|
@danbst Fixed. Thanks! |
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Broken due to NixOS#23216. (cherry picked from commit d7674da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
phpfpm currently uses
readFileto read the php.ini file from the phpPackage. This causes php to be build at evaluation time.This eliminates the use of readFile and builds the php.ini at build time.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/) (used the phpfpm service)