bluez also install gatttool #23220
Closed
bluez also install gatttool #23220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we also need |
|
Seems you have pushed something else to this branch now (simavr). |
|
Hi, i got the impression that git would stick the pull request to the commits at the time of the request, and further work would not be included? I have the branch so I can do my own stuff with nixpkgs... I didn't realise it would add it to this ticket. |
|
GitHub allows you to update the branch with a Pull Request and this updates the Pull Request. GitLab allows the same with their Merge Requests, by the way. The choice is not on the level of Git, it is determined by the Web UI software anyway. |
|
deprecated by #23540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
bluez does not install gatttool by default, although it does build it.
https://bugzilla.redhat.com/show_bug.cgi?id=1141909
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)