Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fftw: 3.3.5 -> 3.3.6-pl1 #23226

Merged
merged 1 commit into from
Feb 27, 2017
Merged

fftw: 3.3.5 -> 3.3.6-pl1 #23226

merged 1 commit into from
Feb 27, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 26, 2017

Motivation for this change

Some bug-fixes that'll cause a mass-rebuild.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @spwhitt and @vcunat to be potential reviewers.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with a subset of nixpkgs and didn't encouter problems. The changelog only mentions bugfixes.

@vcunat Shall we push to staging?

@vcunat
Copy link
Member

vcunat commented Feb 26, 2017

Yes, I think so.

@magnetophon
Copy link
Member Author

Great.
I've also just tested this with a few pkgs.
How do I find out when hydra finishes building this, so I can test further?

@copumpkin
Copy link
Member

Who depends on this that would cause a mass rebuild?

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

Hmm, it seems not too bad, according to my (incomplete) tool:

1234
^ x86_64-linux
57
^ x86_64-darwin

@vcunat vcunat merged commit 90690e7 into NixOS:master Feb 27, 2017
@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

@magnetophon: it's included in this evaluation of master; only a few hundred jobs are left now. (Binaries are uploaded to the binary cache after each individual build.)

@magnetophon
Copy link
Member Author

@vcunat Thanks. How do I get from nixpkgs commit to hydra eval nr?

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

@magnetophon: I know no good way, but the reverse mapping is easy (Hydra eval -> nixpkgs commit).

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

Of course, evaluation dates do help, especially if you dig further into the past.

@magnetophon
Copy link
Member Author

@vcunat OK thanks.

@magnetophon magnetophon deleted the fftw branch February 27, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants