-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fftw: 3.3.5 -> 3.3.6-pl1 #23226
fftw: 3.3.5 -> 3.3.6-pl1 #23226
Conversation
@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @spwhitt and @vcunat to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this with a subset of nixpkgs and didn't encouter problems. The changelog only mentions bugfixes.
@vcunat Shall we push to staging?
Yes, I think so. |
Great. |
Who depends on this that would cause a mass rebuild? |
Hmm, it seems not too bad, according to my (incomplete) tool:
|
@magnetophon: it's included in this evaluation of master; only a few hundred jobs are left now. (Binaries are uploaded to the binary cache after each individual build.) |
@vcunat Thanks. How do I get from nixpkgs commit to hydra eval nr? |
@magnetophon: I know no good way, but the reverse mapping is easy (Hydra eval -> nixpkgs commit). |
Of course, evaluation dates do help, especially if you dig further into the past. |
@vcunat OK thanks. |
Motivation for this change
Some bug-fixes that'll cause a mass-rebuild.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)