Update Aviation Cockpits config #1567
Conversation
AnticlockwisePropeller
commented
Feb 26, 2017
•
AnticlockwisePropeller
commented
- Standardised mix of tabs and spaces to tabs only
- Added names/descriptions for existing cockpits
- Added support for Fw190, Bearcat, and Su30 cockpits
Cleaned up config, added names/descriptions for existing cockpits, and support for Fw190, Bearcat, and Su30 cockpits
| name = ModuleFuelTanks | ||
| type = Structural | ||
| basemass = -1 | ||
| volume = 20 // |
There was a problem hiding this comment.
And what is this ModuleFuelTanks for, anyway?
With RO using RealFuels, we tend to place resources as TANKS within ModuleFuelTanks
https://github.com/KSP-RO/RealismOverhaul/pull/1569/files#diff-1119e2770a2add02ea460939f55e0d7bR44
There was a problem hiding this comment.
I based the new configs on the original config @NathanKell had written for the Interceptor?Cockpit. I can delete the RESOURCES and put them as TANKS within the ModuleFuelTanks, no probs.
|
Deleted comment with no content and replaced RESOURCES with ModuleFuelTanks TANKS, as suggested. |
|
@AnticlockwisePropeller thanks for the changes. I'd like someone to have a chance to test these in game before they are merged, and that won't be me because I can't build or fly planes 📦 |
|
Took a quick peek at the code. Starting line 26 it's got problems: @resource modifies the first node of that name, but then the changes inside are insertions not additions so the node will have double values. That, and any other cases of that, would need to be fixed. Loving that this is getting more love though! :) |
|
Thanks, Nathan! I'll fix that right away! |
Remove inappropriate "@"s from new modules
Jacked the Starfighter and rear Voodoo seat heights up a bit, so you can see where you're going better in IVA.
| @manufacturer = Sukhoi | ||
| @description = Twin seat fighter cockpit. | ||
| %rescaleFactor = 1.2 // 1.5m end diameter | ||
|
|
There was a problem hiding this comment.
This part has messed up nodes, so add
!node_stack_bottom = DEL
!node_stack_bottom = DEL
!node_stack_top = DEL
node_stack_bottom = 0.0, -2.21851, 0.0, 0.0, -1.0, 0.0, 1
node_stack_top = 0.0, 1.44135, 0.0, 0.0, 1.0, 0.0, 1
There was a problem hiding this comment.
Nice catch! Didn't notice that bc the node was in the right place, just the wrong way around
Fix messed up SU-30 Nodes
|
Looks good to me, including Olympic's fix. |
|
Uh, how do we apply the suggestion? |
