musescore: add darwin-specific package #23204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @vandenoever |
yurrriq
added a commit
to yurrriq/dotfiles
that referenced
this pull request
Feb 26, 2017
|
Did you try to build it from source? |
|
I only tried building the existing package (with |
|
I just tried briefly by adding |
LnL7
reviewed
Feb 27, 2017
| @@ -0,0 +1,34 @@ | |||
| { stdenv, fetchurl, undmg }: | |||
There was a problem hiding this comment.
I think it's better to put this in applications/audio/musescore/darwin.nix
|
@LnL7, will do. |
This is basically a clone of the Homebrew cask version: https://github.com/caskroom/homebrew-cask/blob/master/Casks/musescore.rb
yurrriq
force-pushed
the
add/pkgs/applications/audio/musescore-darwin
branch
from
23bf923
to
22404a0
Compare
|
@LnL7, I've made the change you suggested and rebased. |
LnL7
approved these changes
Feb 28, 2017
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The existing package has:
platforms = platforms.linuxand I wanted a version that works on macOS. The addedmusescore-darwinpackage is basically a clone of the Homebrew cask version and uses the.dmgdistributed by MuseScore.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)