Conversation
We should err on the side of being too broad here. I suggest we give up hope of this being automated and spend some time collecting names from everyone involved. I can do a first pass. |
@@ -0,0 +1,20 @@ | |||
Abel 'Akronix' Serrano Juste |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be a bulleted list? GH render is showing them all on one line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wresuolc markdown needs two spaces to represent a RETURN so
Ben Ennis<space><space>
not
Ben Ennis <space>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we aren't using Markdown at all in this file, should we just rename it to CONTRIBUTORS (sans extension) so it renders as plain text?
Some of the people just did one-line README fixes and stuff. But if you run As a release procedure we could do |
first draft @ https://public.etherpad-mozilla.org/p/pwkFIoEL4e . please edit as needed |
I just noticed we have an empty /CREDITS.md file in the root folder. Not sure if this is the same general concept as CONTRIBUTORS, or if we intended CREDITS.md to have something else: https://github.com/mozilla-services/screenshots/blob/master/CREDITS.md |
I guess CREDITS.md used to refer to a library that we no longer use. I guess we should remove that file. |
@pdehaan I'll land this one |
I did this in PR #2492 |
I generated this file manually using my script from #2380 (comment) — then I trimmed a couple of unwanted contributors (Bizarro and greenkeeperio-bot).
Not sure if the want to turn this into some ./bin/contributors script and hook into the Makefile so we can do this in a more automated way on each release (since we'll presumably have new contributors in the future).
Also noteworthy is that this only determines contributors based on Git commits, and doesn't include names of other people behind the scenes (such as our excellent UX team, UR team, legal team, l20n team, catering team, etc).
Fixes #2380