Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proselint: disable tests and put in correct scope #24214

Merged
merged 1 commit into from Apr 25, 2017

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Mar 22, 2017

Didn't build before due to tests referencing the home directory. Also, it was in
the wrong scope.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NickHu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@NickHu
Copy link
Contributor Author

NickHu commented Mar 22, 2017

cc @alibabzo

@FRidh FRidh assigned FRidh and unassigned FRidh Mar 22, 2017
@7c6f434c 7c6f434c merged commit ba974d4 into NixOS:master Apr 25, 2017
@NickHu NickHu deleted the proselint branch August 22, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants