grub module: fix useOSProber when installing grub as EFI #24206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@symphorien, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @obadz to be potential reviewers. |
|
Will try testing this evening or tomorrow and report back. Thank you! |
|
Can confirm this works for me on the following system with os-prober and grub changes cherry-picked (had to switch to stable since opening the issue):
with my Debian and Windows installations being detected, added to grub menus and booting without any issues. I can also try testing against unstable with this pr merged in, just let me know. Thanks again for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix issue #23958
@pbogdan: can you test this ? I don't have any EFI machine.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)