Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Change uses of XMLHttpRequest to fetch #2261

Closed
ianb opened this issue Mar 2, 2017 · 6 comments
Closed

Change uses of XMLHttpRequest to fetch #2261

ianb opened this issue Mar 2, 2017 · 6 comments
Labels
code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox good first issue server wontfix Closed (without being fixed) because we are discontinuing the server
Milestone
Stretch

Comments

@ianb
Copy link
Contributor

ianb commented Mar 2, 2017 •
edited

The fetch API is the more modern alternative to using XMLHttpRequest. We still have some uses of XMLHttpRequest in addon/webextension/ and these could be replaced. (We have some fetch examples too that you can use for reference.)
@ianb ianb added this to the Stretch milestone Mar 2, 2017
@pdehaan pdehaan mentioned this issue Mar 2, 2017
Closed
@pgadige
Copy link

pgadige commented Mar 7, 2017 •
edited

I'd like to work on this issue. Could you please assign it to me. Thank you.

@ianb
Copy link
Contributor Author

ianb commented Mar 7, 2017

@pgadige : I can't seem to assign it to you, but I'll assign it to myself so someone else doesn't take it (but I'll leave it to you to make the patch!)

@ianb ianb self-assigned this Mar 7, 2017
@pgadige
Copy link

pgadige commented Mar 7, 2017

@ianb thank you very much for holding it up. Could you please try to assign it to me again, now?

@ianb
Copy link
Contributor Author

ianb commented Mar 22, 2017

Seems like there isn't activity on this, resetting assignment

@ianb ianb removed their assignment Mar 22, 2017
@ianb ianb mentioned this issue Apr 5, 2017
Closed
@ianb ianb self-assigned this Apr 10, 2017
@ianb
Copy link
Contributor Author

ianb commented Apr 10, 2017

I started this in the branch xmlhttprequest-to-fetch, but after doing this I'm feeling uncomfortable with the amount of logic being moved around at this late date. I don't think this work should be done until after our first release.

@ianb ianb removed their assignment Apr 10, 2017
@jaredhirsch jaredhirsch mentioned this issue Nov 13, 2017
Merged
@ianb ianb added code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox labels Jan 10, 2018
@ianb ianb added the server wontfix Closed (without being fixed) because we are discontinuing the server label Feb 7, 2019
@ianb
Copy link
Contributor Author

ianb commented Feb 7, 2019

This issue is being closed (without being fixed) because we are discontinuing the Screenshots server.

@ianb ianb closed this as completed Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox good first issue server wontfix Closed (without being fixed) because we are discontinuing the server
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
2 participants
@ianb @pgadige