New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libs: make splitString also split last separator #23851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if technically it's a breaking change, it shouldn't happen most of the time and it makes the function more in line with any other language that I have used.
I would still live to see some tests added to the code before approving the change.
@zimbatm : I've just pushed a commit filling in lib/tests.nix, is that what you meant? (checked it worked by using |
Yeah thanks for taking the time and figuring this out. I suppose we should have a better testing framework in place but that will do. |
The final newline would produce an empty string; let's filter all empty lines as well.
I can't see any unfixed differences due to that PR, at least in nix-env -qa output for the four Hydra platforms.
All problems are probably fixed now. |
you're the best @vcunat |
Why do we merge such a horrible implementation? (The first version was horrible too, of course, but this would have been a good occasion to fix it.) Compare with how Haskell does it (which is better): http://hackage.haskell.org/package/split-0.1.2.3/docs/src/Data-List-Split-Internals.html#splitOn |
@butterflya I'm not sure of what you're complaining about. Do you mean that you want to change the semantic so that |
@zimbatm No, the point I was trying to make is that the Haskell implementation is composed of other functions and is a one liner. The version in Nix is the complete opposite of that. I don't think we should unmerge it again (for the sake of progress), but I am saying that there is much room for improvement. |
I think the (original) author had performance in mind. Nix lists are monolithic arrays, unlike what functional languages typically provide. |
@butterflya in that case the occasion is not lost, you can still propose the improvements in a separate PR. And thanks to the tests provided in this PR it will also make it easier to test for conformance. |
…/overlays * commit 'refs/top-bases/experimental/overlays': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/hack-nix * experimental/overlays: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/hack-nix * commit 'refs/top-bases/experimental/hack-nix': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…erimental/parallel-building * commit 'refs/top-bases/experimental/parallel-building': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…eclipse * commit 'refs/top-bases/experimental/eclipse': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/inkscape * commit 'refs/top-bases/experimental/inkscape': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…lover * commit 'refs/top-bases/experimental/plover': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/nginx': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/opera': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…ed-by-marc-weber * master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…sftpd * commit 'refs/top-bases/experimental/vsftpd': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/php': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/ruby': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/marc-nixos/postfix': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/gimp-git * commit 'refs/top-bases/experimental/gimp-git': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…al/gutenprint * commit 'refs/top-bases/experimental/gutenprint': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…ing' into experimental/nixos-module-resource-tracking * commit 'refs/top-bases/experimental/nixos-module-resource-tracking': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…c-nixos/multi-shell-support * commit 'refs/top-bases/marc-nixos/multi-shell-support': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…d-instances * master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…into experimental/multiple-mysqld-instances * commit 'refs/top-bases/experimental/multiple-mysqld-instances': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…l/mercurial * commit 'refs/top-bases/experimental/mercurial': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/haxe': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/updates * experimental/overlays: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…updates * commit 'refs/top-bases/experimental/updates': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/fonts': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/nix': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* master: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…blender * commit 'refs/top-bases/experimental/blender': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…tal/opencascade * commit 'refs/top-bases/experimental/opencascade': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…marc * experimental/updates: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…al/cups-1.6-and-1.7 * experimental/gutenprint: (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…rimental/cups-1.6-and-1.7 * commit 'refs/top-bases/experimental/cups-1.6-and-1.7': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…nixos/virtualbox-server * commit 'refs/top-bases/marc-nixos/virtualbox-server': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
…/arangodb * commit 'refs/top-bases/experimental/arangodb': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* commit 'refs/top-bases/experimental/marc': (127 commits) djview: 4.10.5 -> 4.10.6 (NixOS#24029) kdiff3: fix build createrepo_c: fix build qtbase-* nitpick: fix list nesting fetchsvn: fixup name guessing after NixOS#23851 feh: 2.18.1 -> 2.18.2 yubikey-manager: init at 0.3.1 readPathsFromFile: fixup after NixOS#23851 pythonPackages.pytest-django: fix hash patch setuptools_scm colort: PR tweaks jam: 2.5 -> 2.6 rapcad: 0.9.5 -> 0.9.8 gthumb: 3.4.4 -> 3.5.1 pqiv: 0.12 -> 2.8.3 potrace: 1.13 -> 1.14 meh: init at unstable-2015-04-11 windowmaker: 0.95.7 -> 0.95.8 colort: init at unstable-2017-03-13 vsftpd: Expose the no_anon_password flag. handbrake: 0.10.5 -> 1.0.3 ...
* libs: make splitString also split last separator * libs: add tests for splitStrings
This should fix #23681.
I have tested using nix-repl, not tested every file using it as hydra should be able to do it better than me.
Hope that helps!