allow setting and deleting of attributes on supported XML::Node types (#3902)

Brandon McGinty-Carroll · bcardiff · commit f1a1adb27ed0 · 2017-03-13T15:08:39.000-03:00
* allow setting and deleting of attributes on supported XML::Node types
diff --git a/src/xml/node.cr b/src/xml/node.cr
@@ -21,19 +21,30 @@ struct XML::Node
   end
 
   # Gets the attribute content for the *attribute* given by name.
-  #
   # Raises `KeyError` if attribute is not found.
   def [](attribute : String) : String
     attributes[attribute].content || raise(KeyError.new("Missing attribute: #{attribute}"))
   end
 
   # Gets the attribute content for the *attribute* given by name.
-  #
   # Returns `nil` if attribute is not found.
   def []?(attribute : String) : String?
     attributes[attribute]?.try &.content
   end
 
+  # Sets *attribute* of this node to *value*.
+  # Raises `XML::Error` if this node does not support attributes.
+  def []=(name : String, value : String)
+    raise XML::Error.new("Can't set attribute of #{type}", 0) unless element?
+    attributes[name] = value
+  end
+
+  # Deletes attribute given by *name*.
+  # Returns attributes value, or `nil` if attribute not found.
+  def delete(name : String)
+    attributes.delete(name)
+  end
+
   # Compares with *other*.
   def ==(other : Node)
     @node == other.@node
