Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: 0.10.6 -> 1.3.0 #23850

Merged
merged 1 commit into from Mar 13, 2017
Merged

radare2: 0.10.6 -> 1.3.0 #23850

merged 1 commit into from Mar 13, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Mar 13, 2017

Motivation for this change

https://twitter.com/radareorg/status/841282993977208833

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@makefu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @aske and @matthiasbeyer to be potential reviewers.

@7c6f434c 7c6f434c merged commit 90f2b24 into NixOS:master Mar 13, 2017
@makefu
Copy link
Contributor Author

makefu commented Mar 13, 2017

@bendlas
Copy link
Contributor

bendlas commented Mar 17, 2017

output path ‘/nix/store/0y1gxfld1xgdbdjkqnm2iznz09n2x88z-radare2-1.3.0.tar.gz’ has sha256 hash ‘1jvda5zy21aglm9i2g04x8ypzpbi50jyisbh09prcywlk53qa0yd’ when ‘08p2vhv6vkqvknwq18xl5wgf843lbpbmb111x23gkkxm6vxvpydd’ was expected

Anybody else seeing this?

@makefu
Copy link
Contributor Author

makefu commented Mar 17, 2017

seems they have changed the release without bumping the minor revision. The original release is stored at https://archive.org/details/radare2-1.3.0.tar

@7c6f434c
Copy link
Member

You seem to have a Twitter conversation with Radare upstream related to this release, maybe you could ask them why didn't they bump the release number?

@makefu
Copy link
Contributor Author

makefu commented Mar 17, 2017

@makefu
Copy link
Contributor Author

makefu commented Mar 17, 2017

https://twitter.com/radareorg/status/842688144164225024 - bug in release script 👍

@7c6f434c
Copy link
Member

Bugs happen, but which version is correct?

@makefu
Copy link
Contributor Author

makefu commented Mar 17, 2017

my guess is that the latest is correct. i tried diffing the two archives and only the write-times differed inside the archive.

We could switch to the github release instead of the "official url".

@bendlas
Copy link
Contributor

bendlas commented Mar 22, 2017

Can we get this resolved please? If nothing else, I'd recommend bendlas@4746530

@7c6f434c
Copy link
Member

OK

@makefu
Copy link
Contributor Author

makefu commented Mar 22, 2017

sorry, lost track of this. cherry-picking 4746530 will hopefully work :)
Otherwise we could use github if the issue returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants