Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tribler: from 6.4.3 to 7.0.0-beta #24202

Merged
merged 1 commit into from Mar 22, 2017

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Mar 22, 2017

removed old unused dependencies,
changed enablePlayer to true by default,
added myself as maintainer.

Motivation for this change

to upgrade tribler from 6.4.3, wich was not working due to dependency in wxPython 2.8, to tribler 7.0.0 beta.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@xvapx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cheecheeo, @edolstra and @dezgeg to be potential reviewers.

@xvapx xvapx mentioned this pull request Mar 22, 2017
50 tasks
@globin globin self-assigned this Mar 22, 2017
removed old unused dependencies,
changed enablePlayer to true by default,
added myself as maintainer.
@globin globin force-pushed the upgrade/tribler-v7.0.0-beta branch from a210aa7 to ad75bff Compare March 22, 2017 14:34
@globin globin merged commit 8869816 into NixOS:master Mar 22, 2017
@xvapx xvapx deleted the upgrade/tribler-v7.0.0-beta branch March 24, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants