nltk: init at 3.2.2 #23659
Merged
nltk: init at 3.2.2 #23659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
Mic92
reviewed
Mar 9, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -283,6 +283,35 @@ in { | |||
| # version of nixpart. | |||
| nixpart0 = callPackage ../tools/filesystems/nixpart/0.4 { }; | |||
|
|
|||
| nltk = buildPythonPackage rec { | |||
There was a problem hiding this comment.
We have a new policy for python to put python packages into a separate file and only reference them here:
See also:
$ chromium "file://$(nix-build --no-out-link doc)//share/doc/nixpkgs/manual.html#contributing-guidelines"
There was a problem hiding this comment.
Oh, I missed that. Will fix!
Mic92
reviewed
Mar 9, 2017
| sha256 = "13m8i393h5mhpyvh5rghxxpax3bscv8li3ynwfdiq0kh8wsdndqv"; | ||
| }; | ||
|
|
||
| buildInputs = [ six ]; |
There was a problem hiding this comment.
Is six only required at build time? If not it should be in propagatedBuildInputs instead.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
NLTK is a useful library for natural language processing.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
for py in 27 33 34 35 ; do nix-build -A python${py}Packages.nltk ; done