DebugID #1233
Merged
DebugID #1233
+100
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 8, 2017
ksp_plugin/part.cpp
Outdated
| @@ -144,6 +153,15 @@ not_null<std::unique_ptr<Part>> Part::ReadFromMessage( | |||
| return part; | |||
| } | |||
|
|
|||
| std::string Part::DebugID() const { | |||
There was a problem hiding this comment.
Upon reflection I'd call this ShortDebugString.
ksp_plugin/part.hpp
Outdated
| @@ -100,8 +101,12 @@ class Part final { | |||
| serialization::Part const& message, | |||
| std::function<void()> deletion_callback); | |||
|
|
|||
| // returns "part name (part ID)". | |||
ksp_plugin/vessel.cpp
Outdated
| @@ -281,6 +289,10 @@ not_null<std::unique_ptr<Vessel>> Vessel::ReadFromMessage( | |||
| return std::move(vessel); | |||
| } | |||
|
|
|||
| std::string Vessel::DebugID() const { | |||
serialization/journal.proto
Outdated
| @@ -748,8 +748,9 @@ message InsertOrKeepVessel { | |||
| message In { | |||
| required fixed64 plugin = 1 [(pointer_to) = "Plugin", (is_subject) = true]; | |||
| required string vessel_guid = 2; | |||
| required int32 parent_index = 3; | |||
| required bool loaded = 4; | |||
| required string vessel_name = 3; | |||
There was a problem hiding this comment.
Don't renumber the fields, it's a bad practice, just use 5 for the vessel_name.
serialization/journal.proto
Outdated
| required int32 main_body_index = 5; | ||
| required QP main_body_world_degrees_of_freedom = 6; | ||
| required QP part_world_degrees_of_freedom = 7; | ||
| required string name = 3; |
serialization/journal.proto
Outdated
| @@ -781,8 +783,9 @@ message InsertUnloadedPart { | |||
| message In { | |||
| required fixed64 plugin = 1 [(pointer_to) = "Plugin", (is_subject) = true]; | |||
| required fixed32 part_id = 2; | |||
| required string vessel_guid = 3; | |||
| required QP from_parent = 4; | |||
| required string name = 3; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.