earlyoom service: init #23135
earlyoom service: init #23135
Conversation
|
@ljli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
| { lib, stdenv, fetchFromGitHub }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "earlyoom"; |
There was a problem hiding this comment.
Name should include the version. Like this:
stdenv.mkDerivation rec {
name = "earlyoom-${version}";
version = ...
...
ljli
force-pushed
the
earlyoom-service-init
branch
from
ff951bb
to
7c655a1
Compare
| ${pkgs.earlyoom}/bin/earlyoom \ | ||
| -m ${toString ecfg.freeMemThreshold} \ | ||
| -s ${toString ecfg.freeSwapThreshold} \ | ||
| ${if ecfg.useKernelOOMKiller then "-k" else ""} \ |
There was a problem hiding this comment.
if cond then str else "" = optionalString cond str.
| homepage = https://github.com/rfjakob/earlyoom; | ||
| license = lib.licenses.mit; | ||
| platforms = lib.platforms.linux; | ||
| maintainers = with lib.maintainers; [ ]; |
There was a problem hiding this comment.
maintainers is empty by default; perhaps you'd consider adding yourself?
There was a problem hiding this comment.
Not for now. But I'll keep an eye on it, if that's ok.
ljli
force-pushed
the
earlyoom-service-init
branch
2 times, most recently
from
9470969
to
8a6dcf5
Compare
ljli
force-pushed
the
earlyoom-service-init
branch
from
8a6dcf5
to
db30cff
Compare
|
The underlying program got merged in the meantime. I'm not using this service anymore, so I'll probably won't maintain this. It should still work, though. Maybe we want this anyway, otherwise feel free to close. |
|
Wat, why we didn't merge this pull request. I might want to use it. |
|
@offlinehacker ah, I interpreted the lack of a response to the last comment as a lack of interest. If you want it, please go ahead and integrate it :) |
|
Linux oom killer is so bad, I will use this in my dev environments, so I'm merging this. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)