Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riak-cs: added test #23105

Closed
wants to merge 1 commit into from
Closed

riak-cs: added test #23105

wants to merge 1 commit into from

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Feb 23, 2017 •
edited

Motivation for this change

We should be able to test Riak CS

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

I notice it is not added to the test top-level. Is that intentional?

grahamc
grahamc reviewed Mar 6, 2017
View reviewed changes
nixos/tests/riak-cs.nix
startAll;

$master->waitForUnit("riak");
$master->sleep(20); # Hopefully this is long enough!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long enough for what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a relic from the riak.nix test. Riak takes a non-deterministic time to boot (configuration depends on how long the boot sequence should be), so (I'm assuming) the original author added the comment that 20 seconds should be long enough for vanilla Riak to boot.

@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

I'll merge after you make this a top-level test.

@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

Hrm. No, I can't -- the test fails for me on my unloaded, fast laptop. Definitely won't pass on hydra.

master# (stanchion@127.0.0.1)1> [os_mon] memory supervisor port (memsup): Erlang has closed
master# [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
master# {"Kernel pid terminated",application_controller,"{application_start_failure,stanchion,{{riak_connect_failed,{{tcp,econnrefused},\"127.0.0.1\",8087}},{stanchion_app,start,[normal,[]]}}}"}
master# Kernel pid terminated (application_controller) ({application_start_failure,stanchion,{{riak_connect_failed,{{tcp,econnrefused},"127.0.0.1",8087}},{stanchion_app,start,[normal,[]]}}})
master: exit status 0

can we use $machine->waitForOpenPort(8087); instead of this arbitrary sleep?

@joachifm
Copy link
Contributor

joachifm commented Jul 2, 2017

@mdaiter are you still working on this?

@mdaiter
Copy link
Contributor Author

mdaiter commented Jul 3, 2017

Not really -- my apologies

@ocharles
Copy link
Contributor

@mdaiter Unfortunately I suggest that we close this then. If anyone disagrees, I'm happy to re-open.

@ocharles ocharles closed this Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mdaiter @joachifm @grahamc @ocharles @pSub